[
https://issues.apache.org/jira/browse/GOBBLIN-2024?focusedWorklogId=911704&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-911704
]
ASF GitHub Bot logged work on GOBBLIN-2024:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Mar/24 22:14
Start Date: 26/Mar/24 22:14
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on code in PR #3902:
URL: https://github.com/apache/gobblin/pull/3902#discussion_r1540173038
##########
gobblin-iceberg/src/main/java/org/apache/gobblin/iceberg/publisher/GobblinMCEPublisher.java:
##########
@@ -214,6 +214,7 @@ public static Metrics getMetrics(State state, Path path,
Configuration conf, Nam
return OrcMetrics.fromInputFile(HadoopInputFile.fromPath(path,
conf), MetricsConfig.getDefault(), mapping);
} catch (Exception e) {
//This means the table is not compatible with iceberg, so return a
dummy metric
+ //todo: throw exception here? as it's corrupted file
Review Comment:
I remove the catch exception part as I verified that the only exception is
because of we cannot open the file, which either indicating we have issue on
HDFS or means it's a corrupted file. We should be safe to just throw exception
and fail the task in this case.
Issue Time Tracking
-------------------
Worklog Id: (was: 911704)
Time Spent: 50m (was: 40m)
> Improve the performance of GobblinMCEWriter
> -------------------------------------------
>
> Key: GOBBLIN-2024
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2024
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> We are seeing slowness in the GobblinMCEWriter, which will cause us huge
> backlog when handling large topic and affect the other topics in the same
> container for GMIP. After benchmark, we identify that we can improve the
> computeSpec part to reduce the duplicate work, also we can add the file size
> information in GMCE to avoid calling HDFS for each file.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
