phet commented on code in PR #3896:
URL: https://github.com/apache/gobblin/pull/3896#discussion_r1540538026
##########
gobblin-service/src/test/java/org/apache/gobblin/service/monitoring/FsJobStatusRetrieverTest.java:
##########
@@ -51,6 +51,7 @@ public void setUp() throws Exception {
ConfigValueFactory.fromAnyRef(stateStoreDir));
this.jobStatusRetriever = new FsJobStatusRetriever(config,
mock(MultiContextIssueRepository.class));
this.mysqlDagActionStore = mock(MysqlDagActionStore.class);
+ // job status monitor stores dag action into dag action store, so need to
mock that behavior to avoid NPE
Review Comment:
I did initially suggest adding such a comment, but as I just mentioned, my
opinion has evolved. the need for mocking here seems a code smell that
`KJSM::addJobStatusToStateStore` is doing too much and ought to be reworked.
following that, no mocking or comment would be required
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
