phet commented on code in PR #3899:
URL: https://github.com/apache/gobblin/pull/3899#discussion_r1540615852
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagementTaskStreamImpl.java:
##########
@@ -118,4 +172,16 @@ private DagTask createDagTask(DagActionStore.DagAction
dagAction, MultiActiveLea
throw new UnsupportedOperationException("Not yet implemented");
}
}
+
+ /* Schedules a reminder for the flow action using {@link
DagActionReminderScheduler} to reattempt the lease after the
+ current leaseholder's grant would have expired.
+ */
+ protected void
scheduleReminderForEvent(MultiActiveLeaseArbiter.LeaseAttemptStatus leaseStatus)
+ throws SchedulerException {
+ if (!this.dagActionReminderScheduler.isPresent()) {
+ throw new RuntimeException(MISSING_OPTIONAL_ERROR_MESSAGE);
+ }
Review Comment:
can't we fail-fast (e.g. in the ctor) when mis-configuration, rather than
waiting JIT once we eventually want to use something to detect the error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
