[
https://issues.apache.org/jira/browse/GOBBLIN-2027?focusedWorklogId=911938&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-911938
]
ASF GitHub Bot logged work on GOBBLIN-2027:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Mar/24 23:23
Start Date: 27/Mar/24 23:23
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3904:
URL: https://github.com/apache/gobblin/pull/3904#discussion_r1542145641
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/LeaseAttemptStatus.java:
##########
@@ -24,10 +24,10 @@
import lombok.Getter;
-/*
- Class used to encapsulate status of lease acquisition attempt and derivations
should contain information specific to
- the status that results. The #getDagAction and
#getMinimumLingerDurationMillis are meant to be overriden and used by
- relevant derived classes.
+/**
+ Class used to encapsulate status of lease acquisition attempts made by {@link
MultiActiveLeaseArbiter} and contains
+ information specific to the status that results. The #getDagAction and
#getMinimumLingerDurationMillis are meant to be
Review Comment:
this is where to use `{@link ...}` syntax:
```
#getDagAction and #getMinimumLingerDurationMillis
```
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/DagManagementDagActionStoreChangeMonitor.java:
##########
@@ -52,7 +52,7 @@ public DagManagementDagActionStoreChangeMonitor(Config
config, int numThreads,
}
/**
- * This implementation passes on the {@link DagActionStore.DagAction} to the
+ * This implementation passes on {@link DagActionStore.DagAction} to the
Review Comment:
"This implementation passes on *the* {@link DagActionStore.DagAction} to
-t-h-e- {@link DagManagement} instead..."
(strike `-t-h-e-`)
Issue Time Tracking
-------------------
Worklog Id: (was: 911938)
Time Spent: 1.5h (was: 1h 20m)
> move DagActionStore from gobblin-runtime to gobblin-service
> -----------------------------------------------------------
>
> Key: GOBBLIN-2027
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2027
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
