umustafi commented on code in PR #3899:
URL: https://github.com/apache/gobblin/pull/3899#discussion_r1543310802
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagementTaskStreamImpl.java:
##########
@@ -167,7 +158,7 @@ private DagTask createDagTask(DagActionStore.DagAction
dagAction, MultiActiveLea
switch (dagActionType) {
case LAUNCH:
- return new LaunchDagTask(dagAction, leaseObtainedStatus);
+ return new LaunchDagTask(dagAction, leaseObtainedStatus,
dagActionStore.get());
Review Comment:
it wouldn't however we use guice to initialize and the `dagActionStore` is
optionally bound in Guice. I am adding a check that will throw if
`DagActionStore` is not present
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
