phet commented on code in PR #3899: URL: https://github.com/apache/gobblin/pull/3899#discussion_r1544688458
########## gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/DagManagerFlowTest.java: ########## @@ -58,6 +58,10 @@ import static org.mockito.Mockito.*; +/** + * Tests the state updates (including updating in-memory state and MysqlDagActionStore) after performing add or cancel + * operations by calling addDag, stopDag, kill, and resume. It also tests flows with and without sla configs. Review Comment: this helps! seems "flow" more in the sense of lifecycle/workflow of dag management, rather than gaas flows (although the two are related). I just mean it doesn't sound to be so much concerning multi-job flow orchestration (as the name could imply) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
