[ 
https://issues.apache.org/jira/browse/GOBBLIN-2030?focusedWorklogId=912418&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-912418
 ]

ASF GitHub Bot logged work on GOBBLIN-2030:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Apr/24 05:11
            Start Date: 01/Apr/24 05:11
    Worklog Time Spent: 10m 
      Work Description: phet commented on code in PR #3908:
URL: https://github.com/apache/gobblin/pull/3908#discussion_r1545962129


##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/work/EagerFsDirBackedWorkUnitClaimCheckWorkload.java:
##########
@@ -30,15 +34,17 @@
 @lombok.NoArgsConstructor // IMPORTANT: for jackson (de)serialization
 @lombok.ToString(callSuper = true)
 public class EagerFsDirBackedWorkUnitClaimCheckWorkload extends 
AbstractEagerFsDirBackedWorkload<WorkUnitClaimCheck> {

Review Comment:
   unclear whether the `EventSubmitterContext` should stay here or actually 
belongs better in the base class... I'll probably need to finish reading the 
impl and reflect on it to form an opinion, but curious: how did you decide? 





Issue Time Tracking
-------------------

    Worklog Id:     (was: 912418)
    Time Spent: 40m  (was: 0.5h)

> Integrate new AutoTroubleshooter with GaaS
> ------------------------------------------
>
>                 Key: GOBBLIN-2030
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-2030
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Matthew Ho
>            Priority: Major
>          Time Spent: 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to