[
https://issues.apache.org/jira/browse/GOBBLIN-2026?focusedWorklogId=912561&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-912561
]
ASF GitHub Bot logged work on GOBBLIN-2026:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Apr/24 03:44
Start Date: 02/Apr/24 03:44
Worklog Time Spent: 10m
Work Description: arpit09 opened a new pull request, #3913:
URL: https://github.com/apache/gobblin/pull/3913
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following
[GOBBLIN-2026](https://issues.apache.org/jira/browse/GOBBLIN-2026) issues and
references them in the PR title.
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
- Currently in the cleaner job, if the OOM error occurs while fetching
dataset versions. We add it to the throwables and then continue with the
execution job of cleaning other dataset versions. This leads to execution going
to the finally clause where the job is exited successfully. With the changes in
the PR, whenever an OOM error occurs it won't be consumed, will be thrown then
and there.
- Due to the changes done in
[PR](https://github.com/apache/gobblin/pull/3883) the log where no deletable
version exists was being printed for every 100 datasets. This PR avoids writing
log when there are no deletable versions.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 912561)
Remaining Estimate: 0h
Time Spent: 10m
> Retention Job should fail on OOM
> --------------------------------
>
> Key: GOBBLIN-2026
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2026
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: misc
> Reporter: Arpit Varshney
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently, while cleaning the log files, the Retention job goes into OOM and
> silently fails when the no of log files is too many. Workflow execution even
> after failure says Success.
> As the job silently fails, user doesn't get to know explicitly about it.
> Hence, when going into OOM, retention job should explicitly fail if it can't
> be proceeded further
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
