Will-Lo commented on code in PR #3911:
URL: https://github.com/apache/gobblin/pull/3911#discussion_r1548823526
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/yarn/GobblinTemporalApplicationMaster.java:
##########
@@ -79,13 +79,14 @@ public GobblinTemporalApplicationMaster(String
applicationName, String applicati
ConfigValueFactory.fromAnyRef(YarnHelixUtils.getContainerNum(containerId.toString()))),
Optional.<Path>absent());
- String containerLogDir =
config.getString(GobblinYarnConfigurationKeys.LOGS_SINK_ROOT_DIR_KEY);
- GobblinYarnLogSource gobblinYarnLogSource = new GobblinYarnLogSource();
- if (gobblinYarnLogSource.isLogSourcePresent()) {
- Path appWorkDir = PathUtils.combinePaths(containerLogDir,
GobblinClusterUtils.getAppWorkDirPath(this.clusterName, this.applicationId),
"AppMaster");
- logCopier = gobblinYarnLogSource.buildLogCopier(this.config,
containerId.toString(), this.fs, appWorkDir);
- this.applicationLauncher
- .addService(logCopier);
+ if (config.hasPath(GobblinYarnConfigurationKeys.LOGS_SINK_ROOT_DIR_KEY)) {
+ String containerLogDir =
config.getString(GobblinYarnConfigurationKeys.LOGS_SINK_ROOT_DIR_KEY);
+ GobblinYarnLogSource gobblinYarnLogSource = new GobblinYarnLogSource();
+ if (gobblinYarnLogSource.isLogSourcePresent()) {
+ Path appWorkDir = PathUtils.combinePaths(containerLogDir,
GobblinClusterUtils.getAppWorkDirPath(this.clusterName, this.applicationId),
"AppMaster");
Review Comment:
The task runner in temporal has the check for this property already built in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
