phet commented on code in PR #3896:
URL: https://github.com/apache/gobblin/pull/3896#discussion_r1552081757
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/KafkaJobStatusMonitor.java:
##########
@@ -217,17 +247,15 @@ protected void
processMessage(DecodeableKafkaRecord<byte[],byte[]> message) {
}
/**
- * Persist job status to the underlying {@link StateStore}.
- * It fills missing fields in job status and also merge the fields with the
- * existing job status in the state store. Merging is required because we
- * do not want to lose the information sent by other GobblinTrackingEvents.
- * @param jobStatus
+ * It fills missing fields in job status and also merge the fields with the
existing job status in the state store.
+ * Merging is required because we do not want to lose the information sent
by other GobblinTrackingEvents.
+ * Returns a pair of current job status after update in this method and the
last previous state for this job wrapped
Review Comment:
out of date
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
