[ 
https://issues.apache.org/jira/browse/GOBBLIN-2023?focusedWorklogId=913102&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-913102
 ]

ASF GitHub Bot logged work on GOBBLIN-2023:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Apr/24 23:04
            Start Date: 04/Apr/24 23:04
    Worklog Time Spent: 10m 
      Work Description: arjun4084346 commented on code in PR #3901:
URL: https://github.com/apache/gobblin/pull/3901#discussion_r1552558368


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/KillDagProc.java:
##########
@@ -69,7 +67,10 @@ protected Optional<Dag<JobExecutionPlan>> 
initialize(DagManagementStateStore dag
   @Override
   protected void act(DagManagementStateStore dagManagementStateStore, 
Optional<Dag<JobExecutionPlan>> dag)
       throws IOException {
+    log.info("Request to kill " + (this.dagNodeId.isPresent() ? " dag node " + 
getDagNodeId() : " dag " + getDagId()));

Review Comment:
   dag id is kinda always inferable form dag node id





Issue Time Tracking
-------------------

    Worklog Id:     (was: 913102)
    Time Spent: 1h 20m  (was: 1h 10m)

> create dag proc that can kill dags/dag nodes
> --------------------------------------------
>
>                 Key: GOBBLIN-2023
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-2023
>             Project: Apache Gobblin
>          Issue Type: Task
>            Reporter: Arjun Singh Bora
>            Priority: Major
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to