phet commented on code in PR #3901:
URL: https://github.com/apache/gobblin/pull/3901#discussion_r1553974327
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/KillDagProc.java:
##########
@@ -67,7 +63,10 @@ protected Optional<Dag<JobExecutionPlan>>
initialize(DagManagementStateStore dag
@Override
protected void act(DagManagementStateStore dagManagementStateStore,
Optional<Dag<JobExecutionPlan>> dag)
throws IOException {
- log.info("Request to kill " + (this.dagNodeId.isPresent() ? " dag node " +
getDagNodeId() : " dag " + getDagId()));
+ log.info("Request to kill dag " + getDagId());
+ if (dagNodeKillRequest) {
+ log.info("Request to kill dag node" + getDagNodeId());
+ }
Review Comment:
let's keep it all part of the same message:
```
log.info("Request to kill dag {} (node: {})", getDagId(),
shouldKillSpecificJob ? getDagNodeId().toString() : "<<all>>")
```
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/KillDagProc.java:
##########
@@ -48,14 +47,11 @@
*/
@Slf4j
public class KillDagProc extends DagProc<Optional<Dag<JobExecutionPlan>>> {
- private final Optional<DagNodeId> dagNodeId;
+ private final boolean dagNodeKillRequest;
Review Comment:
we've inherited potential confusion because "job" and "dagNode" are
basically synonyms. perhaps we should use "job" for what's exposed to users
(e.g. API endpoints and the DagActions" directly created from those) and
"dagNode" for internal mechanics of carrying out those actions. in this case,
I'd opt for "job" terminology, so maybe `shouldKillSpecificJob`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
