phet commented on code in PR #3918:
URL: https://github.com/apache/gobblin/pull/3918#discussion_r1561564212
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/DagActionStoreChangeMonitor.java:
##########
@@ -144,7 +144,12 @@ protected void initializeMonitor() {
}
// TODO: make this multi-threaded to add parallelism
for (DagActionStore.DagAction action : dagActions) {
- handleDagAction(action, true);
+ try {
+ handleDagAction(action, true);
+ } catch (Exception e) {
+ log.error("Ran into an unexpected error processing DagActionStore
changes during initialization for action {}", action, e);
Review Comment:
nit: leave out, "Ran into an "
maybe
```
"Unexpected error initializing from DagActionStore changes, upon {}"
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]