phet commented on PR #3920: URL: https://github.com/apache/gobblin/pull/3920#issuecomment-2052089195
> This would be changing the NPE into an IOException instead right? The underlying issue is that not every source has a CopyEntityClass which is depended on by `ProcessWorkUnitImpl`, it seems that you need to decouple the ProcessWorkUnitImpl with the CopySource since there are different Gobblin sources that can be used. I do agree with addressing the presumption in `ProcessWorkUnitImpl`, but will do so separately. RN the presumption of `CopyEntity` only shows up there for informational logging, but I agree, that it's too `CopySource`-specific for the general case. that said, protecting against NPE by first checking the result seems a reasonable stand-alone change, and this method already has `IOException` in its signature. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
