[
https://issues.apache.org/jira/browse/GOBBLIN-2046?focusedWorklogId=915159&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-915159
]
ASF GitHub Bot logged work on GOBBLIN-2046:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/Apr/24 16:43
Start Date: 17/Apr/24 16:43
Worklog Time Spent: 10m
Work Description: phet opened a new pull request, #3925:
URL: https://github.com/apache/gobblin/pull/3925
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-2046
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
there are many kinds of `WorkUnit`, beyond the `CopyEntity` produced by
`CopySource`.
as it remains helpful, continue to log `CopyEntity`-specific info, but do so
w/o suggesting something is missing when the WU is not a `CopyEntity`
in addition, add logging to
`GobblinYarnAppLauncher::addAppMasterLocalResources` for a rough indication of
where this lengthy phase of pre-launch init is spending so much time
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
manually executed `CopyEntity`-workload and non-`CopyEntity`-workload and
verified intended logging
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 915159)
Remaining Estimate: 0h
Time Spent: 10m
> Generalize gobblin-on-temporal `ProcessWorkUnitImpl` logging not to presume
> `CopyEntity`
> ----------------------------------------------------------------------------------------
>
> Key: GOBBLIN-2046
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2046
> Project: Apache Gobblin
> Issue Type: New Feature
> Components: gobblin-core
> Reporter: Kip Kohn
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> there are many kinds of `WorkUnit`, beyond the `CopyEntity` produced by
> `CopySource`.
> as it remains helpful, continue to log `CopyEntity`-specific info, but do so
> w/o suggesting something is missing when the WU is not a `CopyEntity`
--
This message was sent by Atlassian Jira
(v8.20.10#820010)