ZihanLi58 commented on code in PR #3919:
URL: https://github.com/apache/gobblin/pull/3919#discussion_r1569339137
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/watermark/StringWatermark.java:
##########
@@ -26,19 +26,22 @@
import lombok.AllArgsConstructor;
import lombok.EqualsAndHashCode;
-import lombok.Getter;
/**
* String based {@link ComparableWatermark} implementation.
*/
@AllArgsConstructor
@EqualsAndHashCode
-public class StringWatermark implements ComparableWatermark {
+public class StringWatermark implements ComparableWatermark<String> {
Review Comment:
There is no API change in this class at all. i.e. the getValue still return
String type and the way to construct the class still remain the same. So I
think we don't need test for this part. Let me know if you still have concerns
about this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
