[
https://issues.apache.org/jira/browse/GOBBLIN-2049?focusedWorklogId=915398&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-915398
]
ASF GitHub Bot logged work on GOBBLIN-2049:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Apr/24 21:05
Start Date: 18/Apr/24 21:05
Worklog Time Spent: 10m
Work Description: umustafi opened a new pull request, #3929:
URL: https://github.com/apache/gobblin/pull/3929
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [X] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-2049
### Description
- [X] Here are some details about my PR, including screenshots (if
applicable):
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Gobblin `safeSetPathPermission` does not throw an exception when setting
permissions fail on a path. We want to change this behavior especially for use
cases like manifest distcp where hundreds of thousands of files are involved in
a distcp job and permission settings are important to replicate correctly as
they cannot be updated or verified by hand.
This PR adds a new configuration to fail writing or publishing tasks when
the job is configured to report success when permissions are not replicated
properly. The default behavior remains the same as before to allow the job to
succeed without this for backwards compatibility.
### Commits
- [X] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 915398)
Remaining Estimate: 0h
Time Spent: 10m
> Configure Gobblin Distcp Writer to fail if setPermission fails
> --------------------------------------------------------------
>
> Key: GOBBLIN-2049
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2049
> Project: Apache Gobblin
> Issue Type: New Feature
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Gobblin {{safeSetPathPermission}} does not throw an exception when setting
> permissions fail on a path. We want to change this behavior especially for
> use cases like manifest distcp where hundreds of thousands of files are
> involved in a distcp job and permission settings are important to replicate
> correctly as they cannot be updated or verified by hand.
> This PR adds a new configuration to fail writing or publishing tasks when the
> job is configured to report success when permissions are not replicated
> properly. The default behavior remains the same as before to allow the job to
> succeed without this for backwards compatibility.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
