phet commented on code in PR #3929:
URL: https://github.com/apache/gobblin/pull/3929#discussion_r1571563487
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/publisher/CopyDataPublisher.java:
##########
@@ -95,7 +95,7 @@ public boolean isThreadSafe() {
protected final DataFileVersionStrategy dstDataFileVersionStrategy;
protected final boolean preserveDirModTime;
protected final boolean resyncDirOwnerAndPermission;
- protected final boolean requirePermissionSetForSuccess;
+ protected final boolean shouldFailWhenPermissionFail;
Review Comment:
nit: when permission***s*** fail (preferred!) or when permission fail***s***
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
