ZihanLi58 commented on code in PR #3935:
URL: https://github.com/apache/gobblin/pull/3935#discussion_r1580076431
##########
gobblin-api/src/main/java/org/apache/gobblin/source/extractor/ComparableWatermark.java:
##########
@@ -20,7 +20,7 @@
/**
* {@link Watermark} that is also {@link Comparable}.
*/
-public interface ComparableWatermark<V extends Comparable<V>> extends
Watermark, Comparable<ComparableWatermark>{
+public interface ComparableWatermark<V> extends Watermark,
Comparable<ComparableWatermark>{
Review Comment:
This change enlarge the scope of the general class. And we have two
implementation of this calls, LongWatermark and StringWatermark, both are not
affected with this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
