phet commented on code in PR #3940:
URL: https://github.com/apache/gobblin/pull/3940#discussion_r1586825670


##########
gobblin-metrics-libs/gobblin-metrics-base/src/main/avro/GaaSObservabilityEvent.avsc:
##########


Review Comment:
   although we don't expect ever to use `GaaSObservabilityEventExperimental` 
again, given it was already emitted, probably best to leave that untouched and 
create a new schema.  keep the old ones in the code base for anyone who still 
wishes to generate bindings (e.g. to process existing msgs).  just mark the old 
DEPRECATED / DISUSED and add the new one alongside



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to