[
https://issues.apache.org/jira/browse/GOBBLIN-2061?focusedWorklogId=917629&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917629
]
ASF GitHub Bot logged work on GOBBLIN-2061:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/May/24 20:11
Start Date: 04/May/24 20:11
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3943:
URL: https://github.com/apache/gobblin/pull/3943#discussion_r1590116456
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/core/GobblinServiceManager.java:
##########
@@ -382,7 +387,11 @@ private void registerServicesInLauncher(){
}
}
- this.serviceLauncher.addService(dagManager);
+ if (configuration.isDagProcessingEngineEnabled()) {
Review Comment:
yay - we already have the config to make this optional!
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/LaunchDagProc.java:
##########
@@ -63,8 +63,12 @@ protected Optional<Dag<JobExecutionPlan>>
initialize(DagManagementStateStore dag
try {
FlowSpec flowSpec =
dagManagementStateStore.getFlowSpec(FlowSpec.Utils.createFlowSpecUri(getDagId().getFlowId()));
flowSpec.addProperty(ConfigurationKeys.FLOW_EXECUTION_ID_KEY,
getDagId().getFlowExecutionId());
- return
this.flowCompilationValidationHelper.createExecutionPlanIfValid(flowSpec).toJavaUtil();
- } catch (URISyntaxException | SpecNotFoundException | InterruptedException
e) {
+ Optional<Dag<JobExecutionPlan>> dag =
this.flowCompilationValidationHelper.createExecutionPlanIfValid(flowSpec).toJavaUtil();
+ if (dag.isPresent()) {
+ dagManagementStateStore.checkpointDag(dag.get());
+ }
+ return dag;
Review Comment:
it should just return `Optional.empty`, which `act` checks for just below
YMMV, but I find [this
approach](https://github.com/apache/gobblin/pull/3942#discussion_r1589492017)
to be a clearer signal that an alt. handling path was not missed
Issue Time Tracking
-------------------
Worklog Id: (was: 917629)
Time Spent: 40m (was: 0.5h)
> Fix initialization of DagProcessingEngine
> -----------------------------------------
>
> Key: GOBBLIN-2061
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2061
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> * Initialize DagProcessingEngine with right parameters
> * Add DagProcessingEngine to GobblinServiceManager
> * Add logging to DagProcessingEngine instantiation and Threads
> * Fix instantiation of QuartzScheduler for DagActionReminderScheduler
> * Fix DagAction type retrieval from Quartz reminder job detail map
> *
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
