Will-Lo commented on code in PR #3944:
URL: https://github.com/apache/gobblin/pull/3944#discussion_r1591659081
##########
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/OrchestratorTest.java:
##########
@@ -81,12 +84,15 @@ public class OrchestratorTest {
private FlowCatalog flowCatalog;
private FlowSpec flowSpec;
- private Orchestrator orchestrator;
+
+ private FlowStatusGenerator mockFlowStatusGenerator;
+ private DagManager mockDagManager;
+ private Orchestrator dagMgrNotFlowLaunchHandlerBasedOrchestrator;
private static final String TEST_USER = "testUser";
private static final String TEST_PASSWORD = "testPassword";
private static final String TEST_TABLE = "quotas";
- @BeforeClass
+ @BeforeMethod
Review Comment:
I don't think there's anything wrong with `@BeforeClass` explicitly, it has
its uses when doing expensive setup e.g. DB or Kafka setup and this is done in
some other classes. I would argue that you can have both `BeforeClass` and
`BeforeMethod` depending on your needs, though for this class specifically
`BeforeMethod` makes more sense for mock setup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
