arjun4084346 commented on code in PR #3948:
URL: https://github.com/apache/gobblin/pull/3948#discussion_r1594872228
##########
gobblin-service/src/test/java/org/apache/gobblin/service/modules/core/GobblinServiceHATest.java:
##########
@@ -255,6 +251,8 @@ public void cleanUp() throws Exception {
cleanUpDir(COMMON_SPEC_STORE_PARENT_DIR);
mysql.stop();
+ // `.close()` to avoid (in the aggregate, across multiple suites) -
java.sql.SQLNonTransientConnectionException: Too many connections
+ testMetastoreDatabase.close();
Review Comment:
what if line 253 throws the exception and this statement is never reached
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
