[
https://issues.apache.org/jira/browse/GOBBLIN-2057?focusedWorklogId=918648&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-918648
]
ASF GitHub Bot logged work on GOBBLIN-2057:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/May/24 23:45
Start Date: 09/May/24 23:45
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3938:
URL: https://github.com/apache/gobblin/pull/3938#discussion_r1596104629
##########
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/proc/ResumeDagProcTest.java:
##########
@@ -114,10 +117,8 @@ public void resumeDag() throws IOException,
URISyntaxException {
.filter(a -> a.getMethod().getName().equals("addSpec"))
.count())
.sum();
- long addedDagNodeStates =
Mockito.mockingDetails(this.dagManagementStateStore).getInvocations().stream()
- .filter(a ->
a.getMethod().getName().equals("addDagNodeState")).count();
Assert.assertEquals(resumedJobCount, expectedNumOfResumedJobs);
Review Comment:
wouldn't that actually be better to verify that the spec producer associated
w/ the `DagNode` we expect is the specific one with its `.addSpec` invoked?
Issue Time Tracking
-------------------
Worklog Id: (was: 918648)
Time Spent: 2h 50m (was: 2h 40m)
> create resume dag proc
> ----------------------
>
> Key: GOBBLIN-2057
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2057
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
