phet commented on code in PR #3947: URL: https://github.com/apache/gobblin/pull/3947#discussion_r1600605438
########## gobblin-service/src/main/java/org/apache/gobblin/service/modules/core/GobblinServiceManager.java: ########## @@ -117,7 +117,7 @@ public class GobblinServiceManager implements ApplicationLauncher, StandardMetri public static final String SERVICE_EVENT_BUS_NAME = "GobblinServiceManagerEventBus"; private static final Logger LOGGER = LoggerFactory.getLogger(GobblinServiceManager.class); - private static volatile GobblinServiceGuiceModule GOBBLIN_SERVICE_GUICE_MODULE; + @Setter private static volatile GobblinServiceGuiceModule GOBBLIN_SERVICE_GUICE_MODULE; Review Comment: gotcha. probably deserves a comment like: ``` `@Setter` for use by downstream deployment code (beyond this repo) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
