phet commented on code in PR #3912: URL: https://github.com/apache/gobblin/pull/3912#discussion_r1600607252
########## gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/work/CommitStats.java: ########## @@ -17,17 +17,28 @@ package org.apache.gobblin.temporal.ddm.work; +import java.util.HashMap; import java.util.Map; import lombok.Data; import lombok.NoArgsConstructor; import lombok.NonNull; import lombok.RequiredArgsConstructor; + +/** + * Data structure representing the stats for a committed dataset, and the ottal number of committed workunits in the Gobblin Temporal job Review Comment: "ottal" => "total" ########## gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/work/DatasetStats.java: ########## @@ -22,13 +22,17 @@ import lombok.NonNull; import lombok.RequiredArgsConstructor; + +/** + * Stats for a dataset that was committed. Review Comment: "committed" or merely "processed"? e.g. is it not possible for `successfullyCommitted == false` and `numCommittedWorkunits == 0`? also, looks like a stray blank line in the javadoc comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
