ZihanLi58 commented on code in PR #3949:
URL: https://github.com/apache/gobblin/pull/3949#discussion_r1602353735
##########
gobblin-iceberg/src/main/java/org/apache/gobblin/iceberg/publisher/GobblinMCEPublisher.java:
##########
@@ -115,9 +115,11 @@ public void publishData(Collection<? extends
WorkUnitState> states) throws IOExc
}
protected Map<String, String> getPartitionOffsetRange(String offsetKey) {
- return state.getPropAsList(offsetKey)
Review Comment:
I actually want to return null instead of an empty list in this case. to
make sure I won't call mergeOffset() at all in the icebergMetadataWriter. But
learned this new API. Also getPropAsList() will throw NPE in this case as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
