phet commented on code in PR #3950:
URL: https://github.com/apache/gobblin/pull/3950#discussion_r1605574480
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagementTaskStreamImpl.java:
##########
@@ -162,12 +220,16 @@ private DagTask createDagTask(DagActionStore.DagAction
dagAction, LeaseAttemptSt
DagActionStore.DagActionType dagActionType = dagAction.getDagActionType();
switch (dagActionType) {
+ case ENFORCE_FINISH_DEADLINE:
+ return new EnforceFinishDeadlineDagTask(dagAction,
leaseObtainedStatus, dagActionStore.get());
+ case ENFORCE_START_DEADLINE:
+ return new EnforceStartDeadlineDagTask(dagAction, leaseObtainedStatus,
dagActionStore.get());
Review Comment:
start and finish are typically complements, but that's not the case here,
correct? rather its "job start" and "flow finish".
first off, please add the job or flow qualifier into all of these names -
for: action type, `DagTask`, `DagProc`, etc..
secondly, shall we work to prevent any start vs. finish confusion (from them
operating on different entity levels) by rename to `flowCompletionDeadline`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
