arjun4084346 commented on code in PR #3951:
URL: https://github.com/apache/gobblin/pull/3951#discussion_r1607631032
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/LeaseAttemptStatus.java:
##########
@@ -51,26 +51,23 @@ public long getMinimumLingerDurationMillis() {
public static class NoLongerLeasingStatus extends LeaseAttemptStatus {}
/*
- The participant calling this method acquired the lease for the event in
question. `Dag action`'s flow execution id
- is the timestamp associated with the lease and the time the caller obtained
the lease is stored within the
- `leaseAcquisitionTimestamp` field. The `multiActiveLeaseArbiter` reference
is used to recordLeaseSuccess for the
- current LeaseObtainedStatus via the completeLease method from a caller
without access to the {@link MultiActiveLeaseArbiter}.
+ The participant calling this method acquired the lease for the event in
question.
+ The timestamp associated with the lease is stored in `eventTimeMillis` field
and the time the caller obtained the
+ lease is stored within the`leaseAcquisitionTimestamp` field. Note that the
`Dag action` returned by the lease
+ arbitration attempt will be unchanged for flows that do not adopt the
consensus eventTimeMillis as the flow execution
+ id, so a separate field must be maintained the track the eventTimeMillis
for lease completion. The
Review Comment:
* maintained to track
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
