arjun4084346 commented on code in PR #3950:
URL: https://github.com/apache/gobblin/pull/3950#discussion_r1610495253


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/core/GobblinServiceManager.java:
##########
@@ -168,6 +167,7 @@ public class GobblinServiceManager implements 
ApplicationLauncher, StandardMetri
   @Inject
   @Getter
   private Injector injector;
+  @Getter @Setter private volatile static Injector staticInjector;

Review Comment:
   ok.
   though because the reader of the code would not know that we were once using 
GobblinServiceGuiceModule



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to