[
https://issues.apache.org/jira/browse/GOBBLIN-2075?focusedWorklogId=921459&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921459
]
ASF GitHub Bot logged work on GOBBLIN-2075:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 30/May/24 23:02
Start Date: 30/May/24 23:02
Worklog Time Spent: 10m
Work Description: Will-Lo opened a new pull request, #3956:
URL: https://github.com/apache/gobblin/pull/3956
…odes rather than the other service config keys
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-2075
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
GaaSJobObservabilityEvents want to send data on source and destination node.
The current code uses for example
```
ServiceConfigKeys.FLOW_DESTINATION_IDENTIFIER_KEY
```
However in the multihop flow compiler, source and destination nodes use the
flowgraph configuration keys
```
FlowGraphConfigurationKeys.FLOW_EDGE_DESTINATION_KEY
```
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Unit tests
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 921459)
Remaining Estimate: 0h
Time Spent: 10m
> Use FlowGraphConfigurationKeys configs to identify source and dest node for
> observability events
> ------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-2075
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2075
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> GaaSObservabilityEvents want to send data on source and destination node.
> However, it uses a Service config key that is not present in multihop flow
> compiler. To remedy this, instead use the source and destination node keys
> from the flowgraph
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
