arjun4084346 commented on code in PR #3955:
URL: https://github.com/apache/gobblin/pull/3955#discussion_r1622924851
##########
gobblin-data-management/src/test/java/org/apache/gobblin/data/management/dataset/ManifestBasedDatasetFinderTest.java:
##########
@@ -173,6 +174,34 @@ public void testIgnoreFilesWithSamePermissions() throws
IOException, URISyntaxEx
}
}
+ @Test
+ public void testFindDatasetEmptyRoot() throws Exception {
+ //Get manifest Path
+ String manifestLocation =
getClass().getClassLoader().getResource("manifestBasedDistcpTest/manifestRootDirEmpty.json").getPath();
+
+ // Test manifestDatasetFinder
+ Properties props = new Properties();
+ props.setProperty("gobblin.copy.manifestBased.manifest.location",
manifestLocation);
+ props.setProperty(ConfigurationKeys.DATA_PUBLISHER_FINAL_DIR, "/");
+ ManifestBasedDatasetFinder finder = new
ManifestBasedDatasetFinder(localFs, props);
+ List<ManifestBasedDataset> datasets = finder.findDatasets();
+ Assert.assertEquals(datasets.size(), 1);
+ try (
+ FileSystem sourceFs = Mockito.mock(FileSystem.class);
Review Comment:
just curious, do mocks require a close ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
