phet commented on code in PR #3961:
URL: https://github.com/apache/gobblin/pull/3961#discussion_r1625333466
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/troubleshooter/AutomaticTroubleshooterFactory.java:
##########
@@ -37,10 +37,10 @@ public class AutomaticTroubleshooterFactory {
* If this module is missing, troubleshooter will default to a no-op
implementation.
*
* In addition, even when the "gobblin-troubleshooter" module is present,
troubleshooter can still be disabled
- * with {@link ConfigurationKeys.TROUBLESHOOTER_DISABLED} setting.
+ * with {@link ConfigurationKeys#TROUBLESHOOTER_DISABLED} setting.
* */
- public static AutomaticTroubleshooter createForJob(Config config) {
- AutomaticTroubleshooterConfig troubleshooterConfig = new
AutomaticTroubleshooterConfig(config);
+ public static AutomaticTroubleshooter createForJob(Properties properties) {
+ AutomaticTroubleshooterConfig troubleshooterConfig = new
AutomaticTroubleshooterConfig(properties);
Review Comment:
next time when making a change to a public API to fix a completely
unanticipated runtime error, please add documentation to the actual source code
about what condition must being prevented and how.
e.g. this might live in this javadoc or that of
`AutomaticTroubleshooterConfig` (less preferred)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
