[
https://issues.apache.org/jira/browse/GOBBLIN-2072?focusedWorklogId=922238&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922238
]
ASF GitHub Bot logged work on GOBBLIN-2072:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Jun/24 18:15
Start Date: 05/Jun/24 18:15
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3955:
URL: https://github.com/apache/gobblin/pull/3955#issuecomment-2150673062
##
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3955?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 38.70%. Comparing base
[(`1ca4944`)](https://app.codecov.io/gh/apache/gobblin/commit/1ca4944359fae3a7348a56427a2c38555811e977?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
to head
[(`ae808bf`)](https://app.codecov.io/gh/apache/gobblin/commit/ae808bf3539e082897ae3898fdb874940a7ae10e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 41 commits behind head on master.
> :exclamation: **Current head ae808bf differs from pull request most recent
head afc6edf**
>
> Please [upload](https://docs.codecov.com/docs/codecov-uploader) reports
for the commit afc6edf to get more accurate results.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3955 +/- ##
============================================
- Coverage 46.63% 38.70% -7.94%
+ Complexity 11247 1595 -9652
============================================
Files 2248 388 -1860
Lines 88520 15961 -72559
Branches 9701 1579 -8122
============================================
- Hits 41278 6177 -35101
+ Misses 43510 9291 -34219
+ Partials 3732 493 -3239
```
</details>
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/gobblin/pull/3955?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
Issue Time Tracking
-------------------
Worklog Id: (was: 922238)
Time Spent: 1.5h (was: 1h 20m)
> Permission mismatch in manifest distcp where empty folders are copied
> ---------------------------------------------------------------------
>
> Key: GOBBLIN-2072
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2072
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-core
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Minor
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> In Manifest distcp, empty folders are being set with the incorrect
> permissions in SetPermissionStep after being correctly set in the
> CopyDataPublisher.
> The suspected reason is that the folders themselves are being treated as
> ancestors, and this causes the permission checking of the source and
> destination ancestors to act incorrectly. TODO: We should consolidate our
> permission comparison and logic given that there are a multitude of different
> implementations and they each seem to have their own quirks.
> Correct CopyDataPublisher:
> {code:java}
> Setting destination directory hdfs://cluster/a/b/c owner and permission to
> rwxr-x---{code}
> Incorrect permission commit step:
> {code:java}
> [Azkaban] Setting permission rwxr-xr-x on path /a/b/c{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
