phet commented on code in PR #3965:
URL: https://github.com/apache/gobblin/pull/3965#discussion_r1635195443
##########
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/MysqlUserQuotaManagerTest.java:
##########
@@ -135,7 +135,7 @@ public ChangeCountRunnable(boolean increaseOrDecrease) {
public void run() {
int i = 0;
while (i++ < INCREMENTS) {
- try (Connection connection =
MysqlUserQuotaManagerTest.this.quotaManager.quotaStore.dataSource.getConnection();)
{
+ try (Connection connection =
MysqlUserQuotaManagerTest.this.quotaManager.quotaStore.dataSource.getConnection())
{
Review Comment:
is there a difference vs. the one created in `setUp`/`tearDown` and this
one? do we need both? if so, a comment would be very helpful!
##########
.github/workflows/build_and_test.yaml:
##########
@@ -134,6 +134,7 @@ jobs:
sudo dpkg -l | grep -i mysql
sudo apt-get clean
sudo apt-get install -y mysql-client
+ mysql --host 127.0.0.1 --port 3306 -uroot -ppassword -e "SET
GLOBAL max_connections = 2000"
Review Comment:
are you able to tell whether tests are passing due to this increase or
because of better hygiene of closing connections/statements?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
