[
https://issues.apache.org/jira/browse/GOBBLIN-2089?focusedWorklogId=923690&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-923690
]
ASF GitHub Bot logged work on GOBBLIN-2089:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/Jun/24 12:47
Start Date: 17/Jun/24 12:47
Worklog Time Spent: 10m
Work Description: abhishekmjain opened a new pull request, #3975:
URL: https://github.com/apache/gobblin/pull/3975
…ution doesn't exist
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN-2089) issues and references
them in the PR title.
- https://issues.apache.org/jira/browse/GOBBLIN-2089
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
The current implementation doesn't check for FlowExecution existence before
accepting a KILL or RESUME.
Updated the functions to call GET api first to get the FlowExecution. This
GET api throws a 404 if a FlowExecution doesn't exist.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 923690)
Remaining Estimate: 0h
Time Spent: 10m
> Fix /flowexecutions KILL and RESUME action to return HTTP 404 when flow
> execution doesn't exist
> -----------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-2089
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2089
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-restli
> Reporter: Abhishek Jain
> Assignee: Hung Tran
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When resume or killed is called for a FlowExecution which doesn't exist, we
> return 200 HttpStatus code currently.
> We should return 404 in such scenarios.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
