[
https://issues.apache.org/jira/browse/GOBBLIN-2095?focusedWorklogId=923966&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-923966
]
ASF GitHub Bot logged work on GOBBLIN-2095:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jun/24 21:45
Start Date: 18/Jun/24 21:45
Worklog Time Spent: 10m
Work Description: Will-Lo opened a new pull request, #3981:
URL: https://github.com/apache/gobblin/pull/3981
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-2095
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
When a job is run by a headless account that is not the dataset owner, the
`CreateAndSetPermissionCommitStep` needs to set the file owners and group
appropriately to match the original dataset owner, otherwise it will lead to a
mismatch for the source data.
The reason why the commit step creates folders manually instead of fully
copying them via rename is to avoid the race condition where multiple files may
be publishing with the same file root at the same time, in which case
`fs.mkdirs` in the scenario where the folder does not exist on destination may
append an extra directory level.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 923966)
Remaining Estimate: 0h
Time Spent: 10m
> CreateAndSetPermissionStep needs to set owner and group for created files
> -------------------------------------------------------------------------
>
> Key: GOBBLIN-2095
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2095
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: William Lo
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When the pre-publish step creates a folder (instead of renaming due to
> potential of race conditions), it is important to ensure that the folder
> owner and group is consistent with the source data, if the job is run by a
> user that is not the dataset owner.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
