arjun4084346 commented on code in PR #3982:
URL: https://github.com/apache/gobblin/pull/3982#discussion_r1645203843
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/MysqlMultiActiveLeaseArbiter.java:
##########
@@ -171,6 +173,8 @@ public class MysqlMultiActiveLeaseArbiter implements
MultiActiveLeaseArbiter {
// Complete lease acquisition if values have not changed since lease was
acquired
protected static final String CONDITIONALLY_COMPLETE_LEASE_STATEMENT =
"UPDATE %s SET "
+ "event_timestamp=event_timestamp, lease_acquisition_timestamp = NULL "
+ WHERE_CLAUSE_TO_MATCH_ROW;
+ protected static final int MAX_RETRIES = 3;
+ protected static final long INITIAL_DELAY_FOR_RETRY_MILLIS = 30L;
private static final ThreadLocal<Calendar> UTC_CAL =
Review Comment:
```
private static ExponentialBackoff exponentialBackOff =
ExponentialBackoff.builder().maxRetries(MAX_RETRIES)
.initialDelay(INITIAL_DELAY_FOR_RETRY_MILLIS + (long)
Math.random() * INITIAL_DELAY_FOR_RETRY_MILLIS)
.build();
```
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/MysqlMultiActiveLeaseArbiter.java:
##########
@@ -171,6 +173,8 @@ public class MysqlMultiActiveLeaseArbiter implements
MultiActiveLeaseArbiter {
// Complete lease acquisition if values have not changed since lease was
acquired
protected static final String CONDITIONALLY_COMPLETE_LEASE_STATEMENT =
"UPDATE %s SET "
+ "event_timestamp=event_timestamp, lease_acquisition_timestamp = NULL "
+ WHERE_CLAUSE_TO_MATCH_ROW;
+ protected static final int MAX_RETRIES = 3;
+ protected static final long INITIAL_DELAY_FOR_RETRY_MILLIS = 30L;
private static final ThreadLocal<Calendar> UTC_CAL =
Review Comment:
```
private static ExponentialBackoff exponentialBackOff =
ExponentialBackoff.builder().maxRetries(MAX_RETRIES)
.initialDelay(INITIAL_DELAY_FOR_RETRY_MILLIS + (long)
Math.random() * INITIAL_DELAY_FOR_RETRY_MILLIS)
.build();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
