umustafi commented on code in PR #3984:
URL: https://github.com/apache/gobblin/pull/3984#discussion_r1650175142
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/FlowLaunchHandler.java:
##########
@@ -233,7 +234,7 @@ protected JobDetailImpl
createJobDetailForReminderEvent(JobKey originalKey, JobK
throws SchedulerException {
JobDetailImpl jobDetail = (JobDetailImpl)
this.schedulerService.getScheduler().getJobDetail(originalKey);
jobDetail.setKey(reminderKey);
- JobDataMap jobDataMap = jobDetail.getJobDataMap();
+ JobDataMap jobDataMap = deepCopyJobDataMap(jobDetail.getJobDataMap());
jobDataMap = updatePropsInJobDataMap(jobDataMap, status,
schedulerMaxBackoffMillis);
Review Comment:
clone creates a shallow copy of the Properties object. It seems safer to
provide a deep copy of the jobDataMap (and Properties obj) to be copied which
can be modified in the update method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
