[
https://issues.apache.org/jira/browse/GOBBLIN-2098?focusedWorklogId=924177&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-924177
]
ASF GitHub Bot logged work on GOBBLIN-2098:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jul/24 16:57
Start Date: 02/Jul/24 16:57
Worklog Time Spent: 10m
Work Description: pratapaditya04 commented on code in PR #3986:
URL: https://github.com/apache/gobblin/pull/3986#discussion_r1653298786
##########
gobblin-metastore/src/test/java/org/apache/gobblin/metastore/testing/TestMetastoreDatabaseServer.java:
##########
@@ -83,10 +83,10 @@ class TestMetastoreDatabaseServer implements Closeable {
if (this.embeddedMysqlEnabled) {
mySQLContainer = new MySQLContainer<>("mysql:" + MYSQL_VERSION)
.withUsername(this.dbUserName)
- .withPassword(this.dbUserPassword)
- .withEnv(MYSQL_ROOT_PASSWORD, "");
-
+ .withPassword(this.dbUserPassword);
mySQLContainer.start();
+ mySQLContainer.withEnv(MYSQL_ROOT_PASSWORD_KEY, ROOT_PASSWORD);
Review Comment:
No, the tests are running in local , only failing in CI pipeline because the
root password in github actions is different than the user password. Actually,
I guess, mysqlcontainer is not allowing the root password to be different than
the user password. Have changed the root password in github action to be same
as user. Have updated the PR
if (this.password != null && !this.password.isEmpty()) {
this.addEnv("MYSQL_PASSWORD", this.password);
this.addEnv("MYSQL_ROOT_PASSWORD", this.password);
Issue Time Tracking
-------------------
Worklog Id: (was: 924177)
Time Spent: 20m (was: 10m)
> Updating the test Mysql version, and getting rid of
> com.wix:wix-embedded-mysql(deprected) in favour of org.testcontainers
> -------------------------------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-2098
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2098
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Aditya Pratap Singh
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Updating the test Mysql version, and getting rid of
> com.wix:wix-embedded-mysql(deprected) in favour of org.testcontainers
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
