umustafi commented on code in PR #3995:
URL: https://github.com/apache/gobblin/pull/3995#discussion_r1669419286
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagActionReminderScheduler.java:
##########
@@ -128,23 +128,27 @@ public void execute(JobExecutionContext context) {
}
/**
- * Creates a key for the reminder job by concatenating all dagAction fields
+ * Creates a key for the reminder job by concatenating all dagAction fields
and the eventTime of the dagAction to
+ * allow reminders for actions associated with multiple flow executions
within a deadline period (e.g. another
+ * flow execution may occur before a flow finish or job start deadline
expires)
Review Comment:
I believe there is a valid scenario to have multiple kill (or resume)
`dagActions` on the same flow execution that are requested far enough apart
(let's say 30 sec apart) to be considered unique events and we were not able to
handle storage of reminders for the same actionType on the same execution. If
epsilon is 20 sec and the requests are 30 sec apart they're distinct, but if
the reminder is 90 sec then there is overlap for storing these reminders in the
scheduler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
