umustafi commented on PR #3996: URL: https://github.com/apache/gobblin/pull/3996#issuecomment-2219154425
> [I pointed out](https://github.com/apache/gobblin/pull/3944/files#r1591517872) in my earlier PR (you linked to) that we're missing test cases. I had added ones relating to my change. what would it take to exercise any of the bug fixes that motivate these latest mods? I added a unit test `testDeleteFlowSpecCalledForMultiActivePath` that validates that the `compileAndSubmitFlowToDagManager` used by the `DagActionStoreChangeMonitor` attempts deleting adhoc `flowSpecs` from the catalog. Note that this test does not definitively ensure that this method is called by the `DagActionStoreChangeMonitor` which proves more complex but verifies if that method is used then the flow will be deleted after compilation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
