umustafi commented on code in PR #3998:
URL: https://github.com/apache/gobblin/pull/3998#discussion_r1674683497
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagActionReminderScheduler.java:
##########
@@ -56,19 +59,28 @@
@Slf4j
@Singleton
public class DagActionReminderScheduler {
+ public static final String DAG_ACTION_REMINDER_SCHEDULER_NAME =
"DagActionReminderScheduler";
public static final String RetryReminderKeyGroup = "RetryReminder";
public static final String DeadlineReminderKeyGroup = "DeadlineReminder";
- private final Scheduler quartzScheduler;
Review Comment:
why not private?
##########
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/DagActionReminderSchedulerTest.java:
##########
@@ -109,4 +115,52 @@ public void testRemindersForMultipleFlowExecutions()
throws SchedulerException {
this.dagActionReminderScheduler.unscheduleReminderJob(launchLeaseParams,
true);
this.dagActionReminderScheduler.unscheduleReminderJob(launchLeaseParams2,
true);
}
+
+ @Test
+ public void testScheduleReminder() throws SchedulerException,
InterruptedException, IOException {
Review Comment:
add comment that ur testing creating of reminder with static method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
