[
https://issues.apache.org/jira/browse/GOBBLIN-2109?focusedWorklogId=925721&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-925721
]
ASF GitHub Bot logged work on GOBBLIN-2109:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jul/24 00:27
Start Date: 13/Jul/24 00:27
Worklog Time Spent: 10m
Work Description: Will-Lo opened a new pull request, #4000:
URL: https://github.com/apache/gobblin/pull/4000
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-2109
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
This PR adds some minor fixes to ensure that permissions setting in Manifest
distcp correctly resets folder permissions after adding execute bit along with
tests, and ensures that the ownerAndPermission list is reset in between the
writers and the commit step by using list iterator
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Unit tests
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 925721)
Remaining Estimate: 0h
Time Spent: 10m
> Fix minor permission issues with setPermissionCommitStep in Manifest distcp
> ---------------------------------------------------------------------------
>
> Key: GOBBLIN-2109
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2109
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: William Lo
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Manifest distcp setPermissionCommitStep is always sending in an empty map
> instead of the intended paths and permissions without the execute bit.
> Additionally, fix a potential bug in the writer owner and permissions object
> with `ensureDirectoryExists` uses a list iterator in case the iterator for
> owner and permissions list is already iterated on.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
