[ 
https://issues.apache.org/jira/browse/GOBBLIN-2110?focusedWorklogId=926209&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-926209
 ]

ASF GitHub Bot logged work on GOBBLIN-2110:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/Jul/24 19:27
            Start Date: 16/Jul/24 19:27
    Worklog Time Spent: 10m 
      Work Description: arjun4084346 commented on code in PR #4001:
URL: https://github.com/apache/gobblin/pull/4001#discussion_r1679964966


##########
gobblin-utility/src/main/java/org/apache/gobblin/util/retry/RetryerFactory.java:
##########
@@ -53,10 +59,14 @@ public class RetryerFactory<T> {
   // value large or equal to 1
   public static final String RETRY_TIMES = "retry_times";
 
-  private static final Predicate<Throwable> RETRY_EXCEPTION_PREDICATE;
+  // Key to store a comma-separated list of exception class names that should 
be retried
+  public static final String EXCEPTION_LIST_FOR_RETRY_CONFIG_KEY = 
"EXCEPTION_LIST_FOR_RETRY";

Review Comment:
   maybe we can move this line along with 
https://github.com/apache/gobblin/blob/master/gobblin-api/src/main/java/org/apache/gobblin/configuration/ConfigurationKeys.java#L1063





Issue Time Tracking
-------------------

    Worklog Id:     (was: 926209)
    Time Spent: 20m  (was: 10m)

> Make retry_exception_predicate configurable in RetryerFactory
> -------------------------------------------------------------
>
>                 Key: GOBBLIN-2110
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-2110
>             Project: Apache Gobblin
>          Issue Type: Bug
>            Reporter: Aditya Pratap Singh
>            Priority: Minor
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Make retry_exception_predicate configurable in RetryerFactory



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to