[
https://issues.apache.org/jira/browse/GOBBLIN-2115?focusedWorklogId=926552&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-926552
]
ASF GitHub Bot logged work on GOBBLIN-2115:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jul/24 20:24
Start Date: 18/Jul/24 20:24
Worklog Time Spent: 10m
Work Description: umustafi commented on code in PR #3999:
URL: https://github.com/apache/gobblin/pull/3999#discussion_r1683438110
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagStateStoreWithDagNodes.java:
##########
@@ -33,9 +33,22 @@
* {@link DagStateStore#cleanUp(DagManager.DagId)} should be used to delete
all the {@link Dag.DagNode}s for a {@link Dag}.
*/
public interface DagStateStoreWithDagNodes extends DagStateStore {
+
+ /**
+ * updates a dag node identified by the provided {@link
org.apache.gobblin.service.modules.orchestration.DagManager.DagId}
Review Comment:
nit can you capitalize the first word of these docs. Explain what the int it
returns represents
Issue Time Tracking
-------------------
Worklog Id: (was: 926552)
Time Spent: 2h 20m (was: 2h 10m)
> implement fully mysql based DMSS
> --------------------------------
>
> Key: GOBBLIN-2115
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2115
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)