umustafi commented on code in PR #3999:
URL: https://github.com/apache/gobblin/pull/3999#discussion_r1683438110
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagStateStoreWithDagNodes.java:
##########
@@ -33,9 +33,22 @@
* {@link DagStateStore#cleanUp(DagManager.DagId)} should be used to delete
all the {@link Dag.DagNode}s for a {@link Dag}.
*/
public interface DagStateStoreWithDagNodes extends DagStateStore {
+
+ /**
+ * updates a dag node identified by the provided {@link
org.apache.gobblin.service.modules.orchestration.DagManager.DagId}
Review Comment:
nit can you capitalize the first word of these docs. Explain what the int it
returns represents
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
