arjun4084346 commented on code in PR #3983:
URL: https://github.com/apache/gobblin/pull/3983#discussion_r1683516935
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagementTaskStreamImpl.java:
##########
@@ -220,17 +230,17 @@ private DagTask createDagTask(DagActionStore.DagAction
dagAction, LeaseAttemptSt
switch (dagActionType) {
case ENFORCE_FLOW_FINISH_DEADLINE:
- return new EnforceFlowFinishDeadlineDagTask(dagAction,
leaseObtainedStatus, dagManagementStateStore);
+ return new EnforceFlowFinishDeadlineDagTask(dagAction,
leaseObtainedStatus, dagManagementStateStore, dagProcEngineMetrics);
case ENFORCE_JOB_START_DEADLINE:
- return new EnforceJobStartDeadlineDagTask(dagAction,
leaseObtainedStatus, dagManagementStateStore);
+ return new EnforceJobStartDeadlineDagTask(dagAction,
leaseObtainedStatus, dagManagementStateStore, dagProcEngineMetrics);
case KILL:
- return new KillDagTask(dagAction, leaseObtainedStatus,
dagManagementStateStore);
+ return new KillDagTask(dagAction, leaseObtainedStatus,
dagManagementStateStore, dagProcEngineMetrics);
case LAUNCH:
- return new LaunchDagTask(dagAction, leaseObtainedStatus,
dagManagementStateStore);
+ return new LaunchDagTask(dagAction, leaseObtainedStatus,
dagManagementStateStore, dagProcEngineMetrics);
case REEVALUATE:
- return new ReevaluateDagTask(dagAction, leaseObtainedStatus,
dagManagementStateStore);
+ return new ReevaluateDagTask(dagAction, leaseObtainedStatus,
dagManagementStateStore, dagProcEngineMetrics);
case RESUME:
- return new ResumeDagTask(dagAction, leaseObtainedStatus,
dagManagementStateStore);
+ return new ResumeDagTask(dagAction, leaseObtainedStatus,
dagManagementStateStore, dagProcEngineMetrics);
Review Comment:
this does not look good but sadly i do not have any easy alternate
suggestion for dag tasks to have dagProcEngineMetrics
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
