[jira] [Work logged] (GOBBLIN-2117) Initialize metrics map for DagProcEngineMetrics

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/GOBBLIN-2117?focusedWorklogId=926948&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-926948
 ]

ASF GitHub Bot logged work on GOBBLIN-2117:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/Jul/24 19:54
            Start Date: 22/Jul/24 19:54
    Worklog Time Spent: 10m 
      Work Description: arjun4084346 commented on code in PR #4007:
URL: https://github.com/apache/gobblin/pull/4007#discussion_r1687071873


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/task/DagProcessingEngineMetrics.java:
##########
@@ -75,6 +75,7 @@ public DagProcessingEngineMetrics() {
     List<Tag<?>> tags = new ArrayList<>();
     tags.add(new Tag<>(MetricTagNames.METRIC_BACKEND_REPRESENTATION, 
GobblinMetrics.MetricType.COUNTER));
     this.metricContext = Instrumented.getMetricContext(new State(), 
this.getClass(), tags);
+    registerAllMetrics();

Review Comment:
   ```
   public DagProcessingEngineMetrics() {
       this(Instrumented.getMetricContext(new State(), 
DagProcessingEngineMetrics.class, Collections.singleton(new 
Tag<>(MetricTagNames.METRIC_BACKEND_REPRESENTATION, 
GobblinMetrics.MetricType.COUNTER))));
     }```
     this works





Issue Time Tracking
-------------------

    Worklog Id:     (was: 926948)
    Time Spent: 1.5h  (was: 1h 20m)

> Initialize metrics map for DagProcEngineMetrics
> -----------------------------------------------
>
>                 Key: GOBBLIN-2117
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-2117
>             Project: Apache Gobblin
>          Issue Type: Bug
>          Components: gobblin-service
>            Reporter: Urmi Mustafi
>            Assignee: Abhishek Tiwari
>            Priority: Major
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> ` No meter exists for dagActionType ENFORCE_JOB_START_DEADLINE in metricsMap 
> {}`
> Initialize metrics map for each `dagActionType` in default constructor of 
> `DagProcessingEngineMetrics`



--
This message was sent by Atlassian Jira
(v8.20.10#820010)