Will-Lo commented on code in PR #4026:
URL: https://github.com/apache/gobblin/pull/4026#discussion_r1717640592
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/ResumeDagProc.java:
##########
@@ -71,6 +71,7 @@ protected void act(DagManagementStateStore
dagManagementStateStore, Optional<Dag
long flowResumeTime = System.currentTimeMillis();
// Set the flow and its failed or cancelled nodes to PENDING_RESUME so
that the flow will be resumed from the point before it failed
+ failedDag.get().setFlowEvent(TimingEvent.FlowTimings.FLOW_PENDING_RESUME);
Review Comment:
Setting the flowEvent doesn't mean that the event gets emitted immediately.
Do you want to change that behavior?
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/LaunchDagProc.java:
##########
@@ -77,6 +80,10 @@ protected void act(DagManagementStateStore
dagManagementStateStore, Optional<Dag
dagProcEngineMetrics.markDagActionsAct(getDagActionType(), false);
} else {
DagProcUtils.submitNextNodes(dagManagementStateStore, dag.get(),
getDagId());
+ dag.get().setFlowEvent(TimingEvent.FlowTimings.FLOW_RUNNING);
+ DagManagerUtils.emitFlowEvent(eventSubmitter, dag.get(),
TimingEvent.FlowTimings.FLOW_RUNNING);
Review Comment:
We want to make sure this is just emit a single time - it shouldn't create
multiple flow launch events for a multihop dag flow, correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
